fix: Update screenshot plugin for compatibility with CSS vars. #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes the screenshot plugin to be compatible with the changes in RaspberryPiFoundation/blockly#8671 which fixes RaspberryPiFoundation/blockly#8272
Proposed Changes
It copies the inline style of the injection div to the screenshot svg.
Reason for Changes
The injection div's inline style uses CSS variables to link to the SVG filters that might be used by the blocks in the screenshot.
Test Coverage
No new tests but I manually tested taking screenshots while linking to blockly rc/v12.0.0.
Documentation
N/A
Additional Information
This change isn't necessary until Blockly v12.0.0 is released, but it's compatible with existing Blockly so we might as well fix it now.